From 025ad101ae4bfef28f6183dc1f169da03d182868 Mon Sep 17 00:00:00 2001 From: Derek Perkins Date: Sun, 24 Dec 2023 15:32:11 -0700 Subject: [PATCH] vstreamer: rm excessive logging as is, this makes our vttablet logs unreadable when using message tables Signed-off-by: Derek Perkins --- go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go b/go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go index db5794646da..b2f3fdafec1 100644 --- a/go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go +++ b/go/vt/vttablet/tabletserver/vstreamer/snapshot_conn.go @@ -116,18 +116,15 @@ func (conn *snapshotConn) startSnapshot(ctx context.Context, table string) (gtid defer func() { _, err := lockConn.ExecuteFetch("unlock tables", 0, false) if err != nil { - log.Warning("Unlock tables failed: %v", err) - } else { - log.Infof("Tables unlocked: %v", table) + log.Warning("Unlock tables (%s) failed: %v", table, err) } lockConn.Close() }() tableName := sqlparser.String(sqlparser.NewIdentifierCS(table)) - log.Infof("Locking table %s for copying", table) if _, err := lockConn.ExecuteFetch(fmt.Sprintf("lock tables %s read", tableName), 1, false); err != nil { - log.Infof("Error locking table %s to read", tableName) + log.Warningf("Error locking table %s to read: %v", tableName, err) return "", err } mpos, err := lockConn.PrimaryPosition()