We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipset
Example:
For hash:ip,port, this library defaults to revision=1: https://github.com/vishvananda/netlink/blob/main/ipset_linux.go#L398.
hash:ip,port
revision=1
But the ipset binary code comments indicate we should be using at least revision=3 here (since this library supports using comments with that set type) https://github.com/Olipro/ipset/blob/9f145b49100104d6570fe5c31a5236816ebb4f8f/kernel/net/netfilter/ipset/ip_set_hash_ipport.c#L30
revision=3
For hash:ip, this library defaults to revision=0. But the ipset binary code comments indicate we should be using at least revision=2 here (since this library supports using comments with this set type as well): https://github.com/Olipro/ipset/blob/9f145b49100104d6570fe5c31a5236816ebb4f8f/kernel/net/netfilter/ipset/ip_set_hash_ip.c#L28
hash:ip
revision=0
revision=2
In general, we should probably track the set-level revisions that the ipset binary does.
The text was updated successfully, but these errors were encountered:
Thanks @bleggett Please push a PR
Sorry, something went wrong.
hash:ip{port,net,etc}
Done, thanks!
Successfully merging a pull request may close this issue.
Example:
For
hash:ip,port
, this library defaults torevision=1
: https://github.com/vishvananda/netlink/blob/main/ipset_linux.go#L398.But the
ipset
binary code comments indicate we should be using at leastrevision=3
here (since this library supports using comments with that set type) https://github.com/Olipro/ipset/blob/9f145b49100104d6570fe5c31a5236816ebb4f8f/kernel/net/netfilter/ipset/ip_set_hash_ipport.c#L30For
hash:ip
, this library defaults torevision=0
. But the ipset binary code comments indicate we should be using at leastrevision=2
here (since this library supports using comments with this set type as well): https://github.com/Olipro/ipset/blob/9f145b49100104d6570fe5c31a5236816ebb4f8f/kernel/net/netfilter/ipset/ip_set_hash_ip.c#L28In general, we should probably track the set-level revisions that the
ipset
binary does.The text was updated successfully, but these errors were encountered: