Makefile assumes the voc executable is /opt/voc/bin/voc

[tkurtbond]

It would probably be better to just let voc be found in the path, leaving it up to the user to ensure that. They've most likely installed voc themselves, and know to add the appropriate directories into the PATH.

Here's the trivial patch.
vipack-makefile-patch.txt

[tkurtbond]

Ugh. I see it's more complicated than that. All the dependencies also set VOC to /opt/voc/bin/voc in their Makefiles. I still think that it would be better to let the user set the PATH to specify where the VOC compiler is to be found.

[shekspir55]

agree @tkurtbond, very good point, would you like to open a PR?
we just should make sure that this path is also included.

[norayr]

i pushed the changes you suggested and referenced the issue in the commit.

thank you.

[tkurtbond]

I've been looking at vipack some more, and see that the dependencies that get cloned into github.com/norayr/ mostly have the line "VOC = /opt/voc/bin/voc" in their instance of GNUmakefile; all except unixFileSystem. This makes it very difficult to build vipack if you don't put voc in /opt/voc/bin/voc. I for instance, always put software I install in /usr/local/sw/versions/SOFTWARENAME/SOFTWAREVERSION, because I used to use a Mac, and before I stopped using it Apple had forbidden users to write anywhere outside their home directory except under /usr/local. This has the added benefit that I can have multiple versions of SOFTWARE installed and select which one I want to use by changing my path.

I think it would be better if the location of the voc executable was not hardcoded and just depended on the user having voc in their path. That way it can be found whereever the user put it.

Do you think this would be useful?

If so, would you like me to fork base64, dbg, http, Internet, mbedtls, opts, skprLogger, strutils, and time and change those lines to just "VOC = voc", test building vipack with these changes, and the submit pull requests for each of those repositories?

[norayr]

hello, i agree, i will fix the paths in all vipack 'submodules' tomorrow.

[norayr]

i think i did that, you can test. (: