[Bug] Error with Maplibre 5 and React Map GL (pixelsToGLUnits)
#2460
Labels
Comments
|
Same here ! There is a compatibility problem between react-map-gl and maplibre-gl@5 |
|
See #2457 |
emersion
added a commit
to OpenRailAssociation/osrd-ui
that referenced
this issue
Jan 14, 2025
maplibre-gl v5 causes multiple issues: - The story is broken (JavaScript error trying to set pixelsToGLUnits). Upstream bug report: visgl/react-map-gl#2460 - A new TypeScript error pops up, went unnoticed because CI doesn't fail on these: (!) [plugin typescript] src/components/DataLoader.tsx (61:43): @rollup/plugin-typescript TS2345: Argument of type 'GeoJSONFeature' is not assignable to parameter of type 'MapGeoJSONFeature'. Type 'GeoJSONFeature' is missing the following properties from type '{ layer: (Omit<FillLayerSpecification, "source"> | Omit<LineLayerSpecification, "source"> | Omit<SymbolLayerSpecification, "source"> | ... 5 more ... | Omit<...>) & { ...; }; source: string; sourceLayer?: string | undefined; state: { ...; }; }': layer, source, state /home/simon/src/osrd-ui/ui-warped-map/src/components/DataLoader.tsx:61:43 61 .map((f) => simplifyFeature(f, sourceLayer)); This commit effectively reverts: #797 Signed-off-by: Simon Ser <[email protected]>
emersion
added a commit
to emersion/react-map-gl
that referenced
this issue
Jan 14, 2025
maplibre-gl causes some errors: visgl#2460 Indicate in package.json that react-map-gl is not yet compatible with maplibre-gl v5.
emersion
added a commit
to emersion/react-map-gl
that referenced
this issue
Jan 14, 2025
maplibre-gl v5 causes some errors: visgl#2460 Indicate in package.json that react-map-gl is not yet compatible with maplibre-gl v5.
github-merge-queue bot
pushed a commit
to OpenRailAssociation/osrd-ui
that referenced
this issue
Jan 15, 2025
maplibre-gl v5 causes multiple issues: - The story is broken (JavaScript error trying to set pixelsToGLUnits). Upstream bug report: visgl/react-map-gl#2460 - A new TypeScript error pops up, went unnoticed because CI doesn't fail on these: (!) [plugin typescript] src/components/DataLoader.tsx (61:43): @rollup/plugin-typescript TS2345: Argument of type 'GeoJSONFeature' is not assignable to parameter of type 'MapGeoJSONFeature'. Type 'GeoJSONFeature' is missing the following properties from type '{ layer: (Omit<FillLayerSpecification, "source"> | Omit<LineLayerSpecification, "source"> | Omit<SymbolLayerSpecification, "source"> | ... 5 more ... | Omit<...>) & { ...; }; source: string; sourceLayer?: string | undefined; state: { ...; }; }': layer, source, state /home/simon/src/osrd-ui/ui-warped-map/src/components/DataLoader.tsx:61:43 61 .map((f) => simplifyFeature(f, sourceLayer)); This commit effectively reverts: #797 Signed-off-by: Simon Ser <[email protected]>
|
I encountered the same problem with I resolved both issues by downgrading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I tried to update two of my Astro+React (React Map GL) projects to Maplibre 5 and I am getting an error “
pixelsToGLUnits” for both.I don’t see issues in either repo (Search Maplibre), but React Map GL uses the setting internally.
The new react-maplibre library does not use the setting.
Expected Behavior
No response
Steps to Reproduce
Environment
"react-map-gl": "^7.2.0-beta.1","maplibre-gl": "^4.7.1"works,5.0.xdoes notLogs
No response
The text was updated successfully, but these errors were encountered: