Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM Modality Mapping #17

Open
awdeorio opened this issue Sep 3, 2020 · 2 comments
Open

DICOM Modality Mapping #17

awdeorio opened this issue Sep 3, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@awdeorio
Copy link

awdeorio commented Sep 3, 2020

Is your feature request related to a problem? Please describe.
DICOM messages sometimes include a modality in the field used for identity by TapirX. For example, the XA1020422 is a X-Ray Angiography device.

Describe the solution you'd like
TapirX could check if the identity field starts with one of the modality strings and add a field to the output. Field name could be category.

Describe alternatives you've considered

  • Post-process the output of tapirx with a script
  • Post-process the output of tapirx at a REST API endpoint

EDIT: now that I think more about it, these alternatives might be better.

Additional context
Here are some examples from the wild (exact numbers are modified).

  • WS1234311
  • XA1458615
  • US1776988
  • DX2130302
@awdeorio awdeorio added the enhancement New feature or request label Sep 3, 2020
@ransford
Copy link
Contributor

ransford commented Sep 4, 2020

Do they always match [A-Z]{2,8}[0-9]+? What do the digits mean?

It wouldn't be too taxing to add a map lookup to run after each successful message parse.

@awdeorio
Copy link
Author

awdeorio commented Sep 9, 2020

I don't know if DICOM identifiers are always in the same format. I only have one example to work with.

Of course, the map lookup is easy. The design decision is: is it worth adding a field the Asset object to represent category? Then, plumbing that through to the CSV output, REST API output, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants