New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gift cards controller won't save if order doesn't already have shipping address etc #32

Open

joeswann opened this issue Dec 1, 2016 · 1 comment

joeswann commented Dec 1, 2016

Was running into a problem with the gift_cards_controller rejecting the attempt to add a new line item.

I swapped out the code to use nested attributes and spree's order.contents.add function.

Happy to make a PR or link to commit =)

pikender commented Feb 1, 2017

@joeswann Can you please elaborate the problem faced with steps to reproduce ?

PR for the fix would be great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment