Could not find gift card for auth code when capturing in admin

[joeswann]

Me again sorry. Still very unfamiliar with this code so could be very far off the mark with this.

What I am seeing

• When attempting to capture payment during 'checkout' state I get Could not find gift card for auth code: 23-GC-20161121031428191325 for action: capture
• I am also seeing the payment as not captured when setting Auto capture to true under payment settings and doing a partial payment. This may be by design as auto_capture may assume a full payment and therefore run after the payment step completes?

So steps to recreate the first issue should be

• Spree 3.1
• Create a new gift card in admin
• Add item to cart, proceed through checkout
• Apply Gift Card using the payment step
• Attempt to 'capture' payment in admin before proceeding

Notes:

• The error is generated by app/models/spree/payment_method/gift_card.rb#91
• The error appears to be happening because it's attempting to find (capture) a GiftCardTransaction with the authorization code that doesn't exist (the code does exist on the GiftCard though)
• The transaction is not generated when adding the gift_card because Spree::Order::GiftCard.add_gift_card_payments only generates a payment (with an auth code attached)

The reason I am trying to capture/auto capture is in order to have a correct remaining total (outstanding_total) to send to an offsite payment method when using a gift card for a partial sale.

[joeswann]

Update on this - I'm actually updating better_spree_paypal_express to take other (pending) payments into account when calculating it's totals.

I'm still not sure if it should be possible to capture the gift card before finalising payment though.

[pikender]

@joeswann Have you found the solution to above or took some other workaround ?