Random char replacement breaks password requirements #13
Comments
MichiK
added a commit
to MichiK/pwgen
that referenced
this issue
Jul 28, 2018
If no_ambiguous is set, the ambiguous characters are now replaced one by one instead of throwing away the password and trying to generate a new one. This was a problem when generating long, non-ambiguous passwords. In addition, when symbols, numerals or capital letters are enforced, these characters will no longer be inserted at random positions in the password. Instead, they will only replace lowercase letters, if available. Otherwise, it was possible to e.g. overwrite the single numeral with a symbol if numerals and symbols are set and only one numeral but no symbols were present in the password (closes vinces1979#13).
MichiK
added a commit
to MichiK/pwgen
that referenced
this issue
Jul 28, 2018
If no_ambiguous is set, the ambiguous characters are now replaced one by one instead of throwing away the password and trying to generate a new one. This was a problem when generating long, non-ambiguous passwords. In addition, when symbols, numerals or capital letters are enforced, these characters will no longer be inserted at random positions in the password. Instead, they will only replace lowercase letters, if available. Otherwise, it was possible to e.g. overwrite the single numeral with a symbol if numerals and symbols are set and only one numeral but no symbols were present in the password (closes vinces1979#13).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lets say I run this with
--capitalizeand--numerals, and the following line:passwd = "".join(choice(letters) for x in range(pw_length))returns the string
AbcdefgThe first if
if capitalize...passes, but the second if (if numerals...) will cause a random character to be substituted with a numeral.It's very possible that the character to be substituted is the only capital letter,
A, thereby returning a password that doesn't conform to the requirements--capitalizeand--numerals.The text was updated successfully, but these errors were encountered: