-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade react-native compability from 0.57.* to 0.62.2 #115
base: master
Are you sure you want to change the base?
Conversation
Even the "moving to react-native 0.62.* compatible version of yoga-dom" from the TODO list above was also completed. |
Even Yoga-dom is also upgraded. Pull Request |
Hey! I really appreciate the effort/initiative ya'll have made towards updating this project. Unfortunately it's been over a year now since I've worked on this codebase — my approach was going to be to revisit this project when the Fabric rewrite was complete and more-or-less rewriting the project to match that new architecture. What I didn't anticipate was it taking as long as it has and in that time I've lost more and more context to this project. Losing all that context + the size of a PR like this would require a lot of bandwidth from me to review — and frankly w/ the personal situation I'm in it's bandwidth I just don't have. The last thing I'd want to do however is block you, so here's my recommendation: continue working on your fork and publish your own version (I think using a scoped package name would work best). Once you have your fork fully working (it'd be best to see a non-trivial app running with it), I'd be more than happy to direct people to your updated fork in the readme. |
Thank you for looking at the pull request and suggesting we could go ahead with our fork for now. Since we have new packages for Renderer, CLI, init and some folder restructuring in react-native-dom it would be wise to create separate NPM packages for each. planning to name them as We will keep posting here on the progress of rn-dom-* packages. We were able to bring up movies demo code with this latest upgrade & would host the same on heroku / any other hosting provider. Let me know if you have any other suggestions. |
This branch has been upgraded from react-native 0.57 to 0.62.
Thanks to Gavish, Sasmit and Harpreet for continues contribution in upgrading react-native-dom.
Below are the changes made in brief.
Reasons:
a. deprecation of rnpm and haste modules from react-native
b. implementations/changes done to bring functionalities inline with react-native 0.62 (such as Image.getSize() has been moved from RCTImage to RCTImageLoader)
Reasons:
a. deprecation of rnpm and haste modules from react-native
b. to be inline with react-native's structure.
c. added dom bundling script to CLI and can be invoked using command 'react-native build-dom'
Reasons:
a. deprecation of rnpm
b. to ingest bundling and start commands in package.json.
TODO: