Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support seal-methods/seal-properties as shorthand for psalm-seal-methods #2587

Closed
TysonAndre opened this issue Jan 10, 2020 · 3 comments
Closed

Comments

@TysonAndre
Copy link
Contributor

Having a syntax that wasn't specific to Psalm would be a better indication that the user wants the comment to be interpreted that way in other IDEs or analyzers.

src/Psalm/Internal/Analyzer/CommentAnalyzer.php would need to be changed.

Phan's latest releases support @seal-methods/@seal-properties.

@vimeo vimeo deleted a comment from psalm-github-bot bot Jan 10, 2020
@muglug
Copy link
Collaborator

muglug commented Jan 10, 2020

The behaviour changed in the most recent version so that any time @property or @mixin is given, @psalm-seal-properties is assumed (ditto for @method), but I'm happy to also support @seal-properties/@seal-methods.

@TysonAndre
Copy link
Contributor Author

I know - that makes it less important.

This may help if a class defines __get() to throw if it gets called but doesn't define magic properties, but this is relatively uncommon.

@weirdan
Copy link
Collaborator

weirdan commented Feb 10, 2024

Assumed fixed in #10344

@weirdan weirdan closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants