Merge pull request #10266 from tuqqu/never-parameter-type

Disallow `never` type for parameters
vimeo · Oct 8, 2023 · cad10a1 · cad10a1
2 parents 16be90c + a4cebb2
commit cad10a1
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php b/src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php
@@ -1260,6 +1260,17 @@ private function processParams(
                     );
                 }
 
+                if ($param_type->isNever()) {
+                    IssueBuffer::maybeAdd(
+                        new ReservedWord(
+                            'Parameter cannot be never',
+                            $function_param->type_location,
+                            'never',
+                        ),
+                        $this->suppressed_issues,
+                    );
+                }
+
                 if ($param_type->check(
                     $this->source,
                     $function_param->type_location,

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -3031,6 +3031,17 @@ function hasZeroByteOffset(string $s) : bool {
                     }',
                 'error_message' => 'InvalidScalarArgument',
             ],
+            'disallowNeverTypeForParam' => [
+                'code' => '<?php
+                    function foo(never $_): void
+                    {
+                        return;
+                    }
+                    ',
+                'error_message' => 'ReservedWord',
+                'ignored_issues' => [],
+                'php_version' => '8.1',
+            ],
         ];
     }