Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit list of embed parameters #984

Open
bdougherty opened this issue Apr 2, 2024 · 0 comments
Open

Remove explicit list of embed parameters #984

bdougherty opened this issue Apr 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bdougherty
Copy link
Contributor

I don't remember why this was added in the first place (maybe so we only check valid attributes?) but it has become a bit of a maintenance burden. The data attributes used are already prefixed with data-vimeo- and we know the few special-case ones that can be ignored for oEmbed (data-vimeo-id, data-vimeo-url, data-vimeo-initialized and data-vimeo-defer), so we should be able to safely remove this list.

@bdougherty bdougherty added the enhancement New feature or request label Apr 2, 2024
@bdougherty bdougherty self-assigned this Apr 2, 2024
@bdougherty bdougherty removed their assignment Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant