Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an autocommand to re-add highlight groups #388

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

jez
Copy link
Contributor

@jez jez commented Sep 23, 2023

Fixes #211
Fixes #376

The relevant motivation and summary are in the comment that I've left behind in
the file.

I will mention that this technique is not uncommon:

https://github.com/search?q=%2Fautocmd+ColorScheme%2F&type=code

A similar pattern comes up in most other syntax files that define custom
highlighting groups.

Before

before.mov

After

after.mov

@jez
Copy link
Contributor Author

jez commented Oct 9, 2023

Friendly bump on this! @alerque or @fmoralesc I'd love if one of you two had a moment to take a look at this. Happy to make changes as needed.

Thanks in advance.

@alerque alerque merged commit 16939cd into vim-pandoc:master Nov 26, 2023
1 check passed
@alerque
Copy link
Member

alerque commented Nov 26, 2023

Sorry it took so long for this to hit my radar at a time when I had time to actually read it. It's an obvious win. Thanks for the contribution.

@jez
Copy link
Contributor Author

jez commented Nov 26, 2023

No worries, thanks for the review and Happy Thanksgiving 🙏

@jez jez deleted the jez-autocmd branch November 26, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants