Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daven changes #261

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Daven changes #261

wants to merge 4 commits into from

Conversation

alerque
Copy link
Member

@alerque alerque commented Apr 16, 2019

Looking through the forks of this project I found the following commits that look like they might be generally useful. @davenquinn do you still use these? Are there any known problems with these rules?

davenquinn added 4 commits May 1, 2017 01:27
* master: (70 commits)
  Three improvements to LaTeX highlighting (vim-pandoc#216)
  Add `pandocAmpersandEscape` syntax for &...; special chars (vim-pandoc#205)
  Fix unicode with sub- or superscripts. (vim-pandoc#202)
  Optionally disable definition lists (vim-pandoc#212)
  Add support for tab-indented code blocks (vim-pandoc#207)
  Never conceal \ in \newcommand... (vim-pandoc#197)
  BufFilePRE => BufFilePre (vim-pandoc#199)
  Fixes for parenthetical citations (vim-pandoc#189)
  Fix footnotes. (vim-pandoc#188)
  Fix reference links
  Fix automatic links by restricting characters in mail links.
  Check 'termguicolors' instead of 'nvim'
  fix typo in doc
  fix for upstream issue vim-pandoc#177
  fix typo
  Conceal char for end of code block
  Add cchar for block end
  added endash and emdash support to syntaxt
  fix for neovim
  Use custom syntax group for operators
  ...
@davenquinn
Copy link

Hi @alerque: I've been using this branch for the past few years (since I made the changes) for authoring several papers with no ill effects. The multiline definitions (allowing ; -separated lists of citekeys to be broken over lines) are particularly useful. I can't speak to any issues with merging in master obviously, but they should be fine.

Copy link
Member Author

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to rebase this branch on master to fix the current merge conflicts (which will also drop the unnecessary merge commit) and while you're in there revert the minor irrelevant change I commented on? Otherwise this is looking good...

@@ -81,7 +81,7 @@ endif
if !exists("g:pandoc#syntax#conceal#backslash")
let g:pandoc#syntax#conceal#backslash = 0
endif
"}}}2
"}}}2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an end delimiter for folding, not a string, and does not need this ending quote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants