Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#437] dynamic value generation of option parseReqBody #457

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[#437] dynamic value generation of option parseReqBody #457

wants to merge 3 commits into from

Conversation

v-electrolux
Copy link

@v-electrolux v-electrolux commented Jul 2, 2020 •
edited
Loading

Allows to pass functions as parseReqBody option value

monkpow
monkpow requested changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@monkpow monkpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the patch. I have a couple of discussion points, and a test should be added for the function case.

Let me know any questions :)

README.md Show resolved Hide resolved
app/steps/buildProxyReq.js Show resolved Hide resolved
@v-electrolux
Copy link
Author

added two tests for option parseReqBody as function

@v-electrolux v-electrolux requested a review from monkpow December 14, 2020 15:14
@utay utay mentioned this pull request Mar 3, 2021
Merged
@v-electrolux
Copy link
Author

Friendly poke 👉 @monkpow

@gstvds
Copy link

gstvds commented Jul 29, 2021

Up here!
@monkpow could you take a look at this?

@paxcom-sgarg
Copy link

is this available in 1.6.1

@ermarkar
Copy link

can u please merge this @monkpow !! this really is an important feature!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkpow monkpow Awaiting requested review from monkpow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-electrolux @gstvds @paxcom-sgarg @ermarkar @monkpow