Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous "getHost" implementation. #284 #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxstrauch
Copy link

Solves the problem that the getHost function callback cannot be async.

@monkpow
Copy link
Collaborator

monkpow commented Dec 22, 2018

hey @maxstrauch,
Thanks for this patch. Currently this library is designed to be backward comparable with node 6, and so async is not a supported approach in the source code. You can see that the tests failed for node 6, and if you look at the failure log, it will provide more detail.

I would accept a patch written in Promises form and with a test or two.

Thanks again

@maxstrauch
Copy link
Author

@monkpow I saw it too late that this lib want's to be backwards compatible and I didn't notice it when looking at the code since I only develop in ES6 or Typescript lately ;-)

I'll see what I can get done over the holidays ;-)

@bconnorwhite
Copy link

Fixed with Node 6 support here: #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants