save_file() method error because symbols inside subject

[WU19-1]

Hello, I want to report about an error inside the save_file() method if there is symbols inside the subject because:

def save_file(self, file_path):

        eml_content = self.build_email()

        file_name = str(self.message["Subject"]) + ".eml"

        eml_file_path = os.path.join(file_path, file_name)

        with codecs.open(eml_file_path, mode="wb+", encoding="utf-8") as eml_file:
            eml_file.write(eml_content)

        return eml_file_path

Meanwhile my email has a symbol that are prohibited for filenames < > : " / \ | ? * and inside the save_file() method, these symbols are not removed automatically.

Images:
Code and files inside

File without symbol inside the subject

File with symbol inside the subject

This is my first time submitting an issue, if there's any mistake that I made, I apologize
Thank you very much ! :DDD

[fotis-ntouskas]

Until this gets resolved, here is a solution for cleansing a subject in case it contains OS unsafe characters:

from msg_parser import MsOxMessage
msg_obj = MsOxMessage(<eml_file>)
                    
msg_subject = msg_obj.get_properties()['Subject']
# msg_parser uses email Subject as filename. Since this is not safe, Subject should be cleansed
msg_subject = "".join([c for c in msg_subject if c.isalpha() or c.isdigit()]).rstrip()
# Assign cleansed subject back to email object
msg_obj.subject = msg_subject

msg_obj.save_email_file(<file_path>)