Remove ssr.external settings for "vike" and "vike/server" ?

[thomasjm]

Description

The comment in the relevant code indicates it could be removed once Vike is published in ESM, which seems to be the case now.

This setting is currently standing in the way of me creating a standalone server build by non-externalizing everything that's needed in my server/index.ts file. I had to write a mini Vite plugin to remove the setting as a workaround.

vike/vike/node/plugin/plugins/commonConfig.ts

Lines 22 to 24 in 5095cd9

	// Needed as long as Vike is published as CJS.
	// TODO: can we remove this once Vike is published as ESM?
	external: ['vike', 'vike/server']

This comment gives more context on what I'm trying to do: cyco130/vavite#24 (comment)

[brillout]

Done; thanks for reaching out.