Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shallowRef() instead of shallowReactive() for pageContext and data #198

Open
brillout opened this issue Sep 24, 2024 · 0 comments
Open
Labels
enhancement ✨ New feature or request

Comments

@brillout
Copy link
Member

Slightly but negligible DX regression, but very well worth it as it's much cleaner (much less potential for bugs) and probably a lot more performant. It will also enable Vike to remove this ugly workaround.

@brillout brillout added the enhancement ✨ New feature or request label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant