Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to Action #150

Open
melissa-reynaud-foley opened this issue Sep 26, 2024 · 3 comments
Open

Call to Action #150

melissa-reynaud-foley opened this issue Sep 26, 2024 · 3 comments
Assignees

Comments

@melissa-reynaud-foley
Copy link

Component: Call to Action (full-width)
Action: Adding a background image
Problem: Displays overlapping images in the editor

Notes:

When adding a background image to the Call to Action component, the editor displays 2 overlapping images (you can not see this if the image is positioned in the center).

Overlapping images (centered) - you can't tell there are 2 images:
Overlapping-Images-Centered

Background image is displayed correctly on the published page:
Correct-Image-Centered

It becomes a problem when the image's position is changed and no longer centered - in this case the position is at the very bottom of the image (although it's hard to see for sure because of the top image over it).

Overlapping images in the editor (position of the image has changed) - you can definitely tell there are 2 images:
Overlapping-Images

When published, the bottom image is the one that is displayed (and in the correct position) and the top image does not appear.

Background image is displayed at the correct position on the published page:
Correct-Image

URL: https://wpstarter.vigetx.com/phcc/instructions-sandbox/

@melissa-reynaud-foley
Copy link
Author

It also does the same with solid colors with gradients.

Editor view:
Overlapping-BG-Graident

Correct published view:
Correct-BG-Gradient

@melissa-reynaud-foley
Copy link
Author

Same issue happens with the "Contain" size of the image

Editor view:
Cover-BG-Image-Editor

Published view:
Cover-BG-Image-Published

@melissa-reynaud-foley
Copy link
Author

And with the tile view:

Editor view:
Tile-BG-Image-Editor

Published view:
Tile-BG-Image-Published

@bd-viget bd-viget self-assigned this Oct 17, 2024
bd-viget added a commit that referenced this issue Oct 18, 2024
* [#150] Fix duplicate editor background

* [#150] Don't add unnecessary attribute

* [#150] Reverted previous change due to errors.

* [N/A] Button Hover bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants