-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Pikaraoke should run on a single port (proxy http requests to ffmpeg streams) #303
Comments
Already pulled this into my docker setup... works like a charm 🍻 |
This is on hold because it appears to cause issues with transcoded files when streaming remotely. mp3 + cdg, non-mp4 video formats, and transposed audio will be transcoded. |
What's your docker setup look like? |
Fixed in 1.8.0 Pikaraoke is now very docker friendly! https://hub.docker.com/repository/docker/vicwomg/pikaraoke/general |
Description
People who are hosting pikaraoke are running into issues due to ffmpeg streaming on a different port. This makes it difficult to host pikaraoke outside of the LAN because multiple ports would need to be forwarded. Also, it seems as though Safari is struggling to stream from port 556 #299
Describe the solution you'd like
Have pikaraoke flask server proxy the ffmpeg stream URL, in specific location like /stream
Describe alternatives you've considered
Other solutions involved overriding the ffmpeg url + router proxying or using nginx proxies to achieve the same thing. Too complex for most users.
Additional context
#293 #301
The text was updated successfully, but these errors were encountered: