Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assuming that AC inputs have unique types #1688

Open
blammit opened this issue Nov 3, 2024 · 0 comments
Open

Avoid assuming that AC inputs have unique types #1688

blammit opened this issue Nov 3, 2024 · 0 comments
Milestone

Comments

@blammit
Copy link
Contributor

blammit commented Nov 3, 2024

Currently there is an assumption that AC-in 1 and AC-in 2 always have different types, i.e. they cannot both be grid, or both shore, or both generator. Discussed with Izak in #1626 that this is not a valid assumption:

"It is possible (though probably rare) for both inputs to be generators. It is also technically possible (though probably rare, and almost always a configuration mistake) to configure both inputs the same for any of the other types, so it is probably better if such an assumption isn't made."

Removing this assumption would require some reworking in AcInputs.qml to provide AC input measurements from the individual services, instead of just getting them from system /Ac/ActiveIn/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant