Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback or translations of startpage -> timeout don’t always work? #1665

Open
mpvader opened this issue Oct 31, 2024 · 7 comments
Open

Fallback or translations of startpage -> timeout don’t always work? #1665

mpvader opened this issue Oct 31, 2024 · 7 comments
Assignees
Labels
bug Something isn't working medium_prio
Milestone

Comments

@mpvader
Copy link
Contributor

mpvader commented Oct 31, 2024

this is german,

english does work for me. And german too.. so can’t reproduce. And I expect that soon this will be translated - if you can’t reproduce / don’t see something special, then pls close it as non-reproducible. If there are further reports we can always re open it.

IMG_3352

@mpvader mpvader added bug Something isn't working medium_prio labels Oct 31, 2024
@mpvader mpvader added this to the 1.0.0-fixes milestone Oct 31, 2024
@mpvader mpvader changed the title Fallback or translations of startpage -> display don’t work? Fallback or translations of startpage -> timeout don’t work? Oct 31, 2024
@mpvader mpvader changed the title Fallback or translations of startpage -> timeout don’t work? Fallback or translations of startpage -> timeout don’t always work? Oct 31, 2024
@mpvader
Copy link
Contributor Author

mpvader commented Oct 31, 2024

updated:
image

@chriadam
Copy link
Contributor

chriadam commented Nov 1, 2024

I believe this is (effectively) a duplicate of #1661

@chriadam
Copy link
Contributor

chriadam commented Nov 4, 2024

@dirkjanfaber do you know, was this one also verified to be fixed in v3.51~2? If so, will close.

@dirkjanfaber
Copy link
Contributor

Just tested with Romanian and this page. Looks good! Closing.

image

@dirkjanfaber
Copy link
Contributor

I think we need to re-open this, @chriadam

image

Of course it needs to be translated properly, but as long as the translation isn't there yet, it should show the English variant and not the key.

https://github.com/victronenergy/gui-v2/blob/main/i18n/venus-gui-v2_sv.ts#L8320

@dirkjanfaber dirkjanfaber reopened this Nov 6, 2024
@philipptrenz
Copy link

philipptrenz commented Nov 6, 2024

Another find for the Spanish language on v3.51

See translation here: https://github.com/victronenergy/gui-v2/blob/main/i18n/venus-gui-v2_es.ts#L8437

Bildschirmfoto 2024-11-06 um 10 03 23

@chriadam
Copy link
Contributor

chriadam commented Nov 8, 2024

I should be able to simply install the english catalogue as a fallback catalogue, in case some translation is missing from a non-english translation catalogue in some version.

Note: this will have the downside that it will be more difficult to see these "missing" translations in UI, as English words are less prominent than translation IDs. But, I guess the optimal way to detect missing translations is via lupdate tool rather than with eyes, anyway.

chriadam added a commit that referenced this issue Nov 8, 2024
This ensures that even if another language is chosen as the
active language, if some translated string is missing from
that language's catalogue, the English translation will be
used as a fallback.

Contributes to issue #1665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium_prio
Projects
None yet
Development

No branches or pull requests

4 participants