-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback or translations of startpage -> timeout don’t always work? #1665
Comments
I believe this is (effectively) a duplicate of #1661 |
@dirkjanfaber do you know, was this one also verified to be fixed in v3.51~2? If so, will close. |
I think we need to re-open this, @chriadam Of course it needs to be translated properly, but as long as the translation isn't there yet, it should show the English variant and not the key. https://github.com/victronenergy/gui-v2/blob/main/i18n/venus-gui-v2_sv.ts#L8320 |
Another find for the Spanish language on v3.51 See translation here: https://github.com/victronenergy/gui-v2/blob/main/i18n/venus-gui-v2_es.ts#L8437 |
I should be able to simply install the english catalogue as a fallback catalogue, in case some translation is missing from a non-english translation catalogue in some version. Note: this will have the downside that it will be more difficult to see these "missing" translations in UI, as English words are less prominent than translation IDs. But, I guess the optimal way to detect missing translations is via lupdate tool rather than with eyes, anyway. |
This ensures that even if another language is chosen as the active language, if some translated string is missing from that language's catalogue, the English translation will be used as a fallback. Contributes to issue #1665
this is german,
english does work for me. And german too.. so can’t reproduce. And I expect that soon this will be translated - if you can’t reproduce / don’t see something special, then pls close it as non-reproducible. If there are further reports we can always re open it.
The text was updated successfully, but these errors were encountered: