Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase sensor value limit precision #1587

Open
ReinvdZee opened this issue Oct 16, 2024 · 2 comments
Open

Increase sensor value limit precision #1587

ReinvdZee opened this issue Oct 16, 2024 · 2 comments

Comments

@ReinvdZee
Copy link
Contributor

ReinvdZee commented Oct 16, 2024

Currently, sensor value limits can be specified with 1 digit of precision:

image

This should be increased to at least 2 digits or maybe even 3 digits.
The smallest step the analog inputs can take is 0.005V.

I tested with a power supply and multimeter, the reported value of the ADC can be off by a few mV (e.g., multimeter reports 724 mV, GX reports 0.72V).

I think 2 digits for setting the sensor limits is sufficient. @mpvader?

@mpvader mpvader added this to the Version 1.1.0 milestone Oct 16, 2024
@mpvader
Copy link
Contributor

mpvader commented Oct 16, 2024

Lets change it to two digits

@mpvader
Copy link
Contributor

mpvader commented Oct 16, 2024

From the user:

Safiery Ultrasonics attached to a GX tank.
0 - 4v at maximum tank height (1 metre) but on a smaller tank it’s less. On my tank the range is 0.6v
The GX Tank reads in .005 volt steps. It would be nice to be able to configure in those steps, or simply a button that says “set min” or “set max” which reads the current value to 3 decimal places and sets the min/max.
I’ve had to use dbus-spy to get mine configured correctly.

so, on a second thought, why not simply allow setting it in steps of 0.005V?

Its a bit extreme, but as long as the UI is smart enough wrt accelerating when keeping the button pressed, or add those set min and set max options, then I don’t see why not.

https://community.victronenergy.com/t/bug-sensor-value-a-writeable-field-in-v3-50-24/5179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants