Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connectivity icons #1552

Open
ReinvdZee opened this issue Oct 9, 2024 · 6 comments · May be fixed by #1698
Open

Implement connectivity icons #1552

ReinvdZee opened this issue Oct 9, 2024 · 6 comments · May be fixed by #1698

Comments

@ReinvdZee
Copy link
Contributor

Implement the Wifi and cellular connectivity icons in the status bar, as per the design:

image

Not a blocker for V1.0.0.

@DanielMcInnes
Copy link
Contributor

Hi @ReinvdZee , I can't find these icons in the design, do you know where they are?

@blammit
Copy link
Contributor

blammit commented Oct 22, 2024

@DanielMcInnes Icons are here: https://www.figma.com/design/GjCtz3A3jqSGvyjVvOm6RZ/GX-Touch-design?node-id=2110-140997&node-type=canvas&m=dev

But I think you added some components for the GSM settings a while back, to generate the icons for cellular strength? Don't remember if we added something similar for Wi-Fi settings as well.

@nmbath
Copy link
Contributor

nmbath commented Oct 22, 2024

Would it be possible to also have an icon for ethernet being connected?

@DanielMcInnes
Copy link
Contributor

@DanielMcInnes Icons are here: https://www.figma.com/design/GjCtz3A3jqSGvyjVvOm6RZ/GX-Touch-design?node-id=2110-140997&node-type=canvas&m=dev

But I think you added some components for the GSM settings a while back, to generate the icons for cellular strength? Don't remember if we added something similar for Wi-Fi settings as well.

thanks Bea

@DanielMcInnes
Copy link
Contributor

Would it be possible to also have an icon for ethernet being connected?

We have a meeting later today, I'll bring it up then. @mpvader FYI

@blammit blammit modified the milestones: Version 1.0.0, 1.0.0-fixes Oct 30, 2024
@mpvader mpvader modified the milestones: 1.0.0-fixes, Version 1.1.0 Oct 31, 2024
@mpvader
Copy link
Contributor

mpvader commented Oct 31, 2024

hey @nmbath

Would it be possible to also have an icon for ethernet being connected?

no; too much clutter.

DanielMcInnes added a commit that referenced this issue Nov 5, 2024
DanielMcInnes added a commit that referenced this issue Nov 5, 2024
@DanielMcInnes DanielMcInnes linked a pull request Nov 5, 2024 that will close this issue
DanielMcInnes added a commit that referenced this issue Nov 5, 2024
DanielMcInnes added a commit that referenced this issue Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants