Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaperMemoryStore directory not created, PDF files placed in the wrong location #195

Open
Symbolics opened this issue Jan 4, 2024 · 4 comments
Labels
bug 🐛 Something isn't working work in progress ⚒ Working on it!

Comments

@Symbolics
Copy link

The documentation for Local File Storage says:

"The extension creates a PaperMemoryStore/ folder in your Downloads/"

It does not. Furthermore, the PDFs are placed in ~/Downloads.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a paper on Arxiv
  2. Click on download
  3. Note the location the file is downloaded

Expected behavior
I expect a directory named PaperMemoryStore to be created in the users Downloads folder and the file to be stored there.

Desktop

  • OS: Windows 10
  • Browser: Firefox
  • Version 121.0
  • PaperMemory version: 0.7.0

Additional context
I tried manually creating the PaperMemoryStore folder in ~Downloads directory, however that did not fix the problem.

@vict0rsch
Copy link
Owner

Hi, thanks for letting me know. I'll investigate next week and get back to you.

@vict0rsch vict0rsch added bug 🐛 Something isn't working work in progress ⚒ Working on it! labels Jan 12, 2024
@vict0rsch
Copy link
Owner

vict0rsch commented Feb 27, 2024

I can't reproduce unfortunately...

The only control I have looks like this:

let filename = "PaperMemoryStore/" + payload.title;
filename = filename.replaceAll("?", "").replaceAll(":", "");
chrome.downloads.download({ url: payload.pdfUrl, filename });

It may be a bug in the the browser's chrome.downloads API (it's called chrome on Firefox too). I'll look online

@snunez1
Copy link

snunez1 commented Jul 21, 2024

Following up here. When you say you can't reproduce, do you mean when running on MS Windows and Firefox it places the PDF in ~/Downloads/PaperMemoryStore/ for you?

@vict0rsch
Copy link
Owner

Sorry I missed this. I will have to check with Windows. Unfortunately my bandwidth is very very low for PaperMemory these days :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working work in progress ⚒ Working on it!
Projects
None yet
Development

No branches or pull requests

3 participants