Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] First steps 2 doc figures have low contrast #12647

Closed
dstansby opened this issue Nov 23, 2022 · 2 comments · Fixed by #12703 · May be fixed by vicadesoba/bokeh#1
Closed

[BUG] First steps 2 doc figures have low contrast #12647

dstansby opened this issue Nov 23, 2022 · 2 comments · Fixed by #12703 · May be fixed by vicadesoba/bokeh#1

Comments

@dstansby
Copy link

Software versions

n/a

Browser name and version

No response

Jupyter notebook / Jupyter Lab version

No response

Expected behavior

The figure at https://docs.bokeh.org/en/latest/docs/first_steps/first_steps_2.html#rendering-circles to have high contrast between the figure background and markers.

Observed behavior

Instead the yellow markers on white background are very low contrast and hard to see:
Screenshot 2022-11-23 at 20 18 39

Example code

n/a

Stack traceback or browser console output

No response

Screenshots

No response

@bryevdv
Copy link
Member

bryevdv commented Nov 23, 2022

Hi @dstansby Thank you for this issue, I agree the colors are not very friendly. I had noticed this also in the past, but then forgot to follow up with an issue about it. Would you be interested to submit a PR to improve the color scheme in this example? (Or ideally, any of the first steps examples that need improvement, if you have the interest/bandwidth). The first steps examples are here:

https://github.com/bokeh/bokeh/tree/branch-3.1/docs/bokeh/source/docs/first_steps/examples

A number of new accessible palettes from Paul Tol were added for Bokeh 3.0:

https://docs.bokeh.org/en/latest/docs/reference/palettes.html#accessible-palettes

So colors from those could potentially be used. I have also been preferring background_fill_color="#efefef" lately, but maybe that would confuse/complicate a first steps example. cc @tcmetzger

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants