95 update website documentation for viash 090 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…site-documentation-for-viash-090
…e into 95-update-website-documentation-for-viash-090
|
Grifs
requested changes
Sep 5, 2024
_includes/_clone_template.qmd
Outdated
| @@ -2,7 +2,7 @@ | |||
| ```{r setup, include=FALSE} | |||
| repo_path <- system("git rev-parse --show-toplevel", intern = TRUE) | |||
| proj_dir <- paste0(repo_path, "/guide/_viash_project_template") | |||
| branch <- "v0.2" | |||
| branch <- "main" | |||
There was a problem hiding this comment.
Would it be possible to use a pinned version of the template? It's a serious problem if we ever have to rerun the website render and the template was changed.
There was a problem hiding this comment.
release/0.3.x also works, is that better? or what do you mean by pinned version?
There was a problem hiding this comment.
It looks like the only difference between the release/0.3.0 and main is just a newline. So that should be fine. I suggest to use the v0.3.0 tag though.
Grifs
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated example scripts, guide and quickstart for viash 0.9.0