Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout for L/R Shift and Enter keys is not saved on "Refresh" or "Restart" #206

Open
1 of 4 tasks
rusq opened this issue Sep 24, 2023 · 1 comment · May be fixed by purdeaandrei/vial-qmk-overnumpad-and-aristides-2862#3

Comments

@rusq
Copy link

rusq commented Sep 24, 2023

Hey hey, first of all, I'd like to thank for the great firmware! I'm used to HASU firmware for ADB/USB converter, and was missing the layers on my RPico Unicomp keyboard, thanks to this firmware I'm finally can live my full life.

Please let me know if this is not the right repository for the Vial, or Vial.rocks applications, I'll create this issue elsewhere.

Describe the Bug

The Layout settings for Left and Right Shifts, as well as the size of the Enter key are not saved.

How to reproduce:
1. Set the layout as below:
image

2. Close and open the Vial.app or vial.rocks website OR press Refresh in Vial.app.

3. Layout resets to the following:
image

Hey team, thank you for the great application — I'm using it in conjunction with this firmware.

There's one issue that I have discovered, and I haven't seen it in the existing issues, I'm not sure if this manifests only with this firmware of with the rest too. I don't have any other compatible keyboards to test this.

System Information

Keyboard: Unicomp (with Aristides controller)
Revision (if applicable): Ultra Classic, mfg 2023 (104 keys, ANSI layout)
Operating system: MacOS / Chrome
qmk doctor output:

(qmk is not setup, sorry)

Any keyboard related software installed?

  • AutoHotKey (Windows)
  • Karabiner (macOS)
  • Other
  • None

Additional Context

All other checkboxes in Layout are working fine (retaining state after restart/refresh), as it can be seen on the screenshots.

The keyboard is flashed with unicomp_classic_ultracl_post_2013_aristides_2862_vial.uf2

@NCKiser
Copy link
Contributor

NCKiser commented Nov 6, 2023

Needs #define VIA_EEPROM_LAYOUT_OPTIONS_SIZE 2 in keyboards/unicomp/classic_ultracl_post_2013/keymaps/vial/config.h

NCKiser added a commit to NCKiser/vial-qmk-overnumpad-and-aristides-2862 that referenced this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants