Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Refactor bpmn_validation_success.js #194

Open
redfave opened this issue Aug 31, 2020 · 0 comments
Open

Refactor bpmn_validation_success.js #194

redfave opened this issue Aug 31, 2020 · 0 comments
Assignees

Comments

@redfave
Copy link
Contributor

redfave commented Aug 31, 2020

The generated file bpmn_validation_success.js contains an array noIssuesElements with issues Elements containing the rule name and a success classification.

Example: { "id": "2b9382eb90e2aa912851b1186ca2fbe9", "bpmnFile": "src/main/resources/diagram_2.bpmn", "ruleName": "XorConventionChecker", "elementId": "", "elementName": "", "classification": "SUCCESS", "paths": [], "message": "No issues found" }

This is a misusage of the issue data structure and is misleading as the intention is actually to show that a certain checker hasn't found any errors.

@redfave redfave self-assigned this Aug 31, 2020
@redfave redfave added the fix label Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant