Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters in call hierarchy opens drop-down/Radio Buttons #28

Open
jannisCode opened this issue Oct 17, 2024 · 3 comments
Open

Filters in call hierarchy opens drop-down/Radio Buttons #28

jannisCode opened this issue Oct 17, 2024 · 3 comments
Assignees
Labels
Student An Issue to be Addressed By a Student

Comments

@jannisCode
Copy link

Goal

Change the Filters Button which was put to the Top Bar here: eclipse-jdt/eclipse.jdt.ui#1671 to either a radio button (With 3 icons in the top bar and one is always selected, like the caller/callee option) or a drop down like the Show History List.

Why

I got the idea from other students who told me that that change would make it even more accessible and that intellij does it that way.

If this is something we want to do, I would be happy to implement it!

@jannisCode jannisCode self-assigned this Oct 17, 2024
@jannisCode jannisCode converted this from a draft issue Oct 17, 2024
@jannisCode jannisCode added the Student An Issue to be Addressed By a Student label Oct 17, 2024
@jannisCode
Copy link
Author

Here is a Preview of how it could look like:

Here, obviously we need to find fitting icons (now the three caller icons are a placeholder). With that change one can easily change the callHierarchy.
image

In the second option, you have a dropdown menu. When clicking on the filter icon, the filter Dialog opens, when clicking on the arrow a menu opens as seen below.
image
image

@fedejeanne Please, let me know which one is better an if this is a change worth considdering.

@fedejeanne
Copy link

@fedejeanne Please, let me know which one is better an if this is a change worth considdering.

The change is worth considering and I think it's a good addition. I'll take some time later this week to specify it more thoroughly but here are some spoilers:

  • The button needs another option to open the filters dialog
  • That option is the default and it should happen when one clicks the button (not the dropdown)
  • The (hover) text of the button could/should reflect the currently selected filter (TBD)

@jannisCode
Copy link
Author

jannisCode commented Oct 21, 2024

Good to know, I also think that the dropdown is better that the tree buttons.
The first two Bullet Points are already implemented like that and I will get to work on the third one!

Edit: The thrid Bullet Point also works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Student An Issue to be Addressed By a Student
Projects
Status: 👀 In Review
Development

No branches or pull requests

2 participants