Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change title from "Skip All Breakpoints" to "Unskip All Breakpoints" when toggled #15

Open
HeikoKlare opened this issue Oct 13, 2023 · 5 comments
Assignees
Labels
Enhancement A Request for an Enhancement of an Existing Feature JDT Issues for JDT

Comments

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Oct 13, 2023

Current behavior:

In Windows 11 (see eclipse-platform/eclipse.platform.swt#501), when Skip All Breakpoints is off (deactivated)

Image

... and when it's on (activated)

Image

Expected behavior:

We should change the title to Unskip and possibly icon also.
Propose this and ask Ed Merks (mention him in [the original issue](see eclipse-platform/eclipse.platform.swt#501))

If possible, the icon of the menu (but not then one in the toolbar) should change to a check-mark, like the one in the menu Edit > Smart Insert Mode
image

@HeikoKlare HeikoKlare converted this from a draft issue Oct 13, 2023
@HeikoKlare HeikoKlare added JDT Issues for JDT Enhancement A Request for an Enhancement of an Existing Feature labels Oct 13, 2023
@HeikoKlare
Copy link
Contributor Author

The label could also be changed to a static "Toggle Skip All Breakpoints", similar to all the other options.

@HeikoKlare HeikoKlare moved this from 🆕 New to 🔖 Ready in Eclipse Oct 13, 2023
@HeikoKlare HeikoKlare moved this from 🔖 Ready to 🏗 In progress in Eclipse Nov 20, 2023
@HeikoKlare
Copy link
Contributor Author

@ShahzaibIbrahim ShahzaibIbrahim moved this from 🏗 In progress to 👀 In review in Eclipse Nov 21, 2023
@fedejeanne fedejeanne moved this from 👀 In Review to 🕒 Waiting in Eclipse Nov 27, 2023
@fedejeanne
Copy link

I changed the state of this issue to Waiting because we need to check with Ed if the proposed solution is even acceptable (it would mean a "big visual change").
@ShahzaibIbrahim please check if the expected behavior (having different icons in the toolbar and in the menu) is even possible.

@HeikoKlare
Copy link
Contributor Author

What was the result of checking with Ed?

@fedejeanne
Copy link

Not good: eclipse-platform/eclipse.platform.swt#501 (comment)

At least he didn't reject it so it's up to us to decide.

I say we go ahead with the proposed solution and let the reviewers approve it or reject it. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A Request for an Enhancement of an Existing Feature JDT Issues for JDT
Projects
Status: Blocked
Development

No branches or pull requests

3 participants