-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complain if signatures of the forward declaration and generated code mismatch #810
Labels
Comments
vgvassilev
added a commit
that referenced
this issue
Mar 9, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 9, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 9, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 9, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
Hi @vgvassilev , |
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
@kaushal-malpure, please select one issue and solve it, please do not write under every open issue. |
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 10, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 13, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 13, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 13, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 14, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 14, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 14, 2024
We should be able to diagnose these problems as reported in #810.
vgvassilev
added a commit
that referenced
this issue
Mar 14, 2024
We should be able to diagnose these problems as reported in #810.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clad builds a gradient with a specific signature. It also allows that gradient function signature to be forward-declared. However if both mismatch there are subtle crashes in CodeGen. We should detect such cases and issue an error if they are in the same translation unit:
For example,
clad/test/Gradient/Gradients.C
Line 269 in d7e5434
returns
void
, but the forward declaration is:clad/test/Gradient/Gradients.C
Line 283 in d7e5434
which leads to subtle issues.
The text was updated successfully, but these errors were encountered: