Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pointers in TBR analysis. #691

Open
vaithak opened this issue Dec 29, 2023 · 1 comment
Open

Add support for pointers in TBR analysis. #691

vaithak opened this issue Dec 29, 2023 · 1 comment
Assignees
Milestone

Comments

@vaithak
Copy link
Collaborator

vaithak commented Dec 29, 2023

We have recently added pointer support in reverse mode (#686), but the tests are currently failing when trying to run with the enable-tbr flag. The test file is test/Gadient/Pointers.C.

@vaithak
Copy link
Collaborator Author

vaithak commented Jan 9, 2024

One example which fails in current TBR analysis:

double pointerParam(const double* arr, size_t n) {
  double sum = 0;
  for (size_t i=0; i < n; ++i) {
    size_t* j = &i;
    sum += arr[0] * (*j);
    arr = arr + 1;
  }
  return sum;
}

@davidlange6 davidlange6 added this to the v1.5 milestone Jan 17, 2024
@vgvassilev vgvassilev modified the milestones: v1.5, v1.6 Mar 27, 2024
@vgvassilev vgvassilev assigned ovdiiuv and unassigned PetroZarytskyi Jun 3, 2024
@vgvassilev vgvassilev modified the milestones: v1.6, v1.7 Jul 6, 2024
@vgvassilev vgvassilev modified the milestones: v1.7, 1.8 Jul 18, 2024
@vgvassilev vgvassilev assigned vgvassilev and unassigned ovdiiuv Dec 10, 2024
@vgvassilev vgvassilev modified the milestones: v1.8, v1.9 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants