-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect std::vector
differentiation in the reverse mode
#1070
Labels
Comments
this might be related to #1067 |
gojakuch
added a commit
to gojakuch/clad
that referenced
this issue
Sep 3, 2024
Previously, nullptr used to be set as the derivative of a call in the reverse mode, if there was a custom reverse_forw function available. This issue was overlooked at first, since it doesn't cause any trouble, unless someone decides to use nested operators (such as expressions of the form `a[i] = x*x`). Fixes: vgvassilev#1070
gojakuch
added a commit
to gojakuch/clad
that referenced
this issue
Sep 3, 2024
Previously, nullptr used to be set as the derivative of a call in the reverse mode, if there was a custom reverse_forw function available. This issue was overlooked at first, since it doesn't cause any trouble, unless someone decides to use nested operators (such as expressions of the form `a[i] = x*x`). Fixes: vgvassilev#1070
vgvassilev
pushed a commit
that referenced
this issue
Sep 3, 2024
Previously, nullptr used to be set as the derivative of a call in the reverse mode, if there was a custom reverse_forw function available. This issue was overlooked at first, since it doesn't cause any trouble, unless someone decides to use nested operators (such as expressions of the form `a[i] = x*x`). Fixes: #1070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
expected output:
9
6 0
output:
9
1 0
my assumption as to why this happens is that we don't match the constructor forw and pullback properly. but I'm not sure, it could be that other things are not matched properly as well or that it's another kind of problem.
The text was updated successfully, but these errors were encountered: