You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commit 705d7d0 removed PortTalk-related source files. The files were removed because their copyright holder explicitely states in the header of these files that their distribution is forbidden. Thus, our usage and distribution of those files could potentially be understood as copyright infringiment.
As a side effect, the removal of those headers seem to have broken the build for Windows. I haven't tested the windows build, but I can predict it is broken based on the usage of these functions in VGMPlay.c:
In order to fix the issue, we may consider eighter removing the feature or reimplementing the functionality provided by the concerning PortTalk source files.
The text was updated successfully, but these errors were encountered:
Commit 705d7d0 removed PortTalk-related source files. The files were removed because their copyright holder explicitely states in the header of these files that their distribution is forbidden. Thus, our usage and distribution of those files could potentially be understood as copyright infringiment.
As a side effect, the removal of those headers seem to have broken the build for Windows. I haven't tested the windows build, but I can predict it is broken based on the usage of these functions in VGMPlay.c:
unsigned char OpenPortTalk(void);
void ClosePortTalk(void);
In order to fix the issue, we may consider eighter removing the feature or reimplementing the functionality provided by the concerning PortTalk source files.
The text was updated successfully, but these errors were encountered: