Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable or Reimplement PortTalk features #10

Open
felipesanches opened this issue Feb 17, 2015 · 1 comment
Open

Disable or Reimplement PortTalk features #10

felipesanches opened this issue Feb 17, 2015 · 1 comment
Labels

Comments

@felipesanches
Copy link
Contributor

Commit 705d7d0 removed PortTalk-related source files. The files were removed because their copyright holder explicitely states in the header of these files that their distribution is forbidden. Thus, our usage and distribution of those files could potentially be understood as copyright infringiment.

As a side effect, the removal of those headers seem to have broken the build for Windows. I haven't tested the windows build, but I can predict it is broken based on the usage of these functions in VGMPlay.c:

unsigned char OpenPortTalk(void);
void ClosePortTalk(void);

In order to fix the issue, we may consider eighter removing the feature or reimplementing the functionality provided by the concerning PortTalk source files.

@djtuBIG-MaliceX
Copy link

Remind me to address this by actually raising a PR to replace this for use with inpout32.dll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants