Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface conversion: interface {} is *schema.Set, not []interface {} #3

Closed
mnaser opened this issue Nov 5, 2021 · 4 comments
Closed

Comments

@mnaser
Copy link
Member

mnaser commented Nov 5, 2021

Seems like the most recent change that merged broke things

Not sure if you didn't run into that locally @johanfleury

Also, noticed you're a Montreal local too! 👋

@mnaser
Copy link
Member Author

mnaser commented Nov 5, 2021

The failing build is here:

https://github.com/vexxhost/terraform-provider-uptimerobot/runs/4120019095?check_suite_focus=true

Traceback:

panic: interface conversion: interface {} is *schema.Set, not []interface {}
23

24
goroutine 1185 [running]:
25
github.com/vexxhost/terraform-provider-uptimerobot/internal/provider.resourceMonitorCreate(0xd9bc80, {0xe74f80, 0xc0002458a0})
26
	/home/runner/work/terraform-provider-uptimerobot/terraform-provider-uptimerobot/internal/provider/resource_uptimerobot_monitor.go:149 +0xb15
27
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).Apply(0xc000108c00, 0xc000a901e0, 0xc000213740, {0xe74f80, 0xc0002458a0})
28
	/home/runner/go/pkg/mod/github.com/hashicorp/[email protected]/helper/schema/resource.go:305 +0x438
29
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Provider).Apply(0xc000108d00, 0xc0008f18d8, 0xea992d, 0xf)
30
	/home/runner/go/pkg/mod/github.com/hashicorp/[email protected]/helper/schema/provider.go:289 +0x70
31
github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin.(*GRPCProviderServer).ApplyResourceChange(0xc0000b5818, {0xc000a32540, 0x5035a6}, 0xc000a32540)
32
	/home/runner/go/pkg/mod/github.com/hashicorp/[email protected]/internal/helper/plugin/grpc_provider.go:885 +0x7a5
33
github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0xe72d00, 0xc0000b5818}, {0x1040ef0, 0xc00001da70}, 0xc000a32480, 0x0)
34
	/home/runner/go/pkg/mod/github.com/hashicorp/[email protected]/internal/tfplugin5/tfplugin5.pb.go:3189 +0x170
35
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0000e4c60, {0x1050938, 0xc0007c6000}, 0xc00028b000, 0xc0009c1c80, 0x16503e0, 0x0)
36
	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:995 +0xe0d
37
google.golang.org/grpc.(*Server).handleStream(0xc0000e4c60, {0x1050938, 0xc0007c6000}, 0xc00028b000, 0x0)
38
	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1275 +0xa56
39
google.golang.org/grpc.(*Server).serveStreams.func1.1()
40
	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:710 +0x98
41
created by google.golang.org/grpc.(*Server).serveStreams.func1
42
	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:708 +0xef
43
FAIL	github.com/vexxhost/terraform-provider-uptimerobot/internal/provider	3.758s
44
FAIL

@mnaser
Copy link
Member Author

mnaser commented Nov 5, 2021

I've got a fix for this, pushing now..

@johanfleury
Copy link

johanfleury commented Nov 5, 2021

I’m sorry @mnaser , I should’ve opened this PR as a draft, I wasn’t expecting you to merge right away (I thought acceptance tests would run before).

I made a fix in #4, didn’t see this issue before making the PR.

EDIT: Also, I don’t have a paid account on which I can test those changes, and the provider doesn’t respect UR rate limits (see louy#106), so it keeps crashing when I run the test suite.

EDIT 2: I’m also really not sure if my changes work, and the acceptance test I added doesn’t really ensure that #1 is fixed.

@mnaser
Copy link
Member Author

mnaser commented Nov 5, 2021

Closed in b062d36 and also the rate limits issue has been addressed.

@mnaser mnaser closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants