Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Async runtime #5

Merged
merged 51 commits into from
Dec 22, 2023
Merged

Async runtime #5

merged 51 commits into from
Dec 22, 2023

Conversation

Gavin-Niederman
Copy link
Member

@Gavin-Niederman Gavin-Niederman commented Oct 16, 2023

Add a basic async runtime to pros-rs and make Robot an async trait.

todo before merging:

  • Test the async runtime on real vex hardware

Copy link
Member

@doinkythederp doinkythederp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts and questions I had

pros/examples/accessories.rs Show resolved Hide resolved
pros/src/async_runtime/executor.rs Outdated Show resolved Hide resolved
pros/src/async_runtime/executor.rs Outdated Show resolved Hide resolved
pros/src/async_runtime/executor.rs Show resolved Hide resolved
pros/src/async_runtime/executor.rs Outdated Show resolved Hide resolved
pros/src/async_runtime/mod.rs Outdated Show resolved Hide resolved
pros/src/async_runtime/mod.rs Outdated Show resolved Hide resolved
pros/src/motor.rs Show resolved Hide resolved
Copy link
Member Author

@Gavin-Niederman Gavin-Niederman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused marker

pros/src/async_runtime/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@doinkythederp doinkythederp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some things that might be mistakes and then let's merge

pros/examples/accessories.rs Outdated Show resolved Hide resolved
pros/examples/basic.rs Outdated Show resolved Hide resolved
pros/src/async_runtime/executor.rs Show resolved Hide resolved
pros/src/async_runtime/mod.rs Show resolved Hide resolved
Copy link
Member

@doinkythederp doinkythederp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Lets Go To vex and ask them for Money) 🚀

@Gavin-Niederman Gavin-Niederman merged commit 23c3454 into main Dec 22, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants