Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv6 support #4955

Open
wey-gu opened this issue Nov 29, 2022 · 4 comments
Open

IPv6 support #4955

wey-gu opened this issue Nov 29, 2022 · 4 comments
Labels
help wanted Community: does anyone want to work on it? type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Nov 29, 2022

Introduction

There are some users who require dualstack/ipv6

Contents

https://discuss.nebula-graph.com.cn/t/topic/11247/5

Related work

nebula/src/common/network/NetworkUtils.cpp

Line 74 in 5425036

// we could use inet_ntop instead when we need support for IPv6

@wey-gu wey-gu added the type/enhancement Type: make the code neat or more efficient label Nov 29, 2022
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Nov 29, 2022
@yanglle
Copy link

yanglle commented Nov 29, 2022

We're very much in need

@HarrisChu HarrisChu removed severity/none Severity of bug affects/none PR/issue: this bug affects none version. labels Dec 1, 2022
@wey-gu wey-gu mentioned this issue Dec 3, 2022
Closed
@wqh17101 wqh17101 mentioned this issue Mar 16, 2023
Open
@congguosn
Copy link

congguosn commented Nov 28, 2023 •
edited
Loading

Hi, may I know is ipv6 supported already or not by Nebula? Thanks.

@wey-gu wey-gu added the help wanted Community: does anyone want to work on it? label Nov 28, 2023
@wey-gu
Copy link
Contributor Author

wey-gu commented Nov 29, 2023

As I recall it's not yet supported but this is mainly due to not many such requirements on it, are you interested in PR to support int?

wey-gu added a commit to wey-gu/nebula that referenced this issue Nov 29, 2023
@wey-gu
feat: add IPv6 support
e1d7b00 
close: vesoft-inc#4955

Now it should support dual stack for some friends in community.
This roughly change is targeted to create a branch for their
quick testing on IPv6 only env(that doesnt come with a DNS)

Note intToIPv4 is not handled due to it's probabbly for metad
of NebulaGraph v1 only.
@wey-gu wey-gu mentioned this issue Nov 29, 2023
Open
11 tasks
@wey-gu
Copy link
Contributor Author

wey-gu commented Nov 29, 2023

@congguosn see #5775 for you, you could build and run from your env to see how it goes.

Shishqa pushed a commit to Shishqa/nebula that referenced this issue Aug 15, 2024
@wey-gu @Shishqa
feat: add IPv6 support
1ac00f1 
close: vesoft-inc#4955

Now it should support dual stack for some friends in community.
This roughly change is targeted to create a branch for their
quick testing on IPv6 only env(that doesnt come with a DNS)

Note intToIPv4 is not handled due to it's probabbly for metad
of NebulaGraph v1 only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Community: does anyone want to work on it? type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wey-gu @HarrisChu @yanglle @congguosn