-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submodules: question and suggestion #116
Comments
Those three submodules have been removed, just delete these folders. |
It syncs with the wiki page directly, and it is a repository itself. Therefore, a submodule is used. It was renamed to
It was a submodule because there were SVG fixes not present in the NuGet package which was very outdated. This dependency is now removed, you can delete it.
It currently points to my fork until LayoutFarm/Typography#192 is merged.
That was before I discovered https://github.com/asc-community/AngouriMath. I planned to wrap a JavaScript math evaluation library. That is now removed. You can delete it safely. (I didn't like MathNet.Symbolics's API design.) |
There are currently |
Any more questions? |
Just nuking and re-cloning my repo now. |
Cloning from VS works and runs the forms example project. |
Okay, problem has been solved. |
AngouriMath has a nuget package so we should use that (assuming that the projects dependent on it should remain in this repo). |
Sometimes you need to do |
What does |
I mean |
Seems to be automatic Visual Studio regeneration of Android designer files. |
Just do a |
So the problem is those repos haven't set up their gitignores right? |
For |
Maybe... |
With git submodules, bugs in their setup become bugs in CSharpMath's setup, so those need to be fixed to get CSharpMath's git into a working state. |
These aren't really bugs as GitHub Actions can run successfully. I also didn't experience this when working locally. |
Modified submodules will not count as changes in commits, so you can still commit fine. |
We definitely need to reference AngouriMath from a nuget package, if it is retained at all. It's peripheral to this repo and warnings about it appear on build if it is submodule referenced. |
I have a dedicated
I will retain this and will not remove it.
I define core and peripheral as projects in the
That is not a problem for me. You can submit a PR to fix the warnings to AngouriMath if they really bother you. |
Given that submodules are used, what is the way to use them with Visual Studio?
git submodule update -- init
works sometimes but not always.Still leaves
If we get instructions here we can then put them on the main page. Currently I have to ask @Happypig375 for submodule maintenance every time I try to work with the repo.
Also can we review what submodules are needed?
The text was updated successfully, but these errors were encountered: