Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.IllegalArgumentException: Duplicate handler name: idle In 3.5.1 #97

Open
dushibaiyu opened this issue May 30, 2018 · 4 comments

Comments

@dushibaiyu
Copy link

When set NetServer Option IdleTimeout > 0
In file io.vertx.core.net.impl.NetServerImpl at function initChannel at line 145~147 will add 'idle' handler to pipeline

And in file io.vertx.mqtt.impl.MqttServerImpl on function initChannel at line 141 will add a 'idle' hander too, it will throw the erro exception

I think should change the last 'idle' to 'mqttIdle'

@Sammers21
Copy link
Contributor

@dushibaiyu, can you try with the 3.6.0-SNAPSHOT version?

@dushibaiyu
Copy link
Author

@Sammers21 in the master it will has the error:
Beause in io.vertx.mqtt.impl.MqttServerImpl on function initChannel at line 141: pipeline.addBefore("handler", "idle", new IdleStateHandler(this.options.timeoutOnConnect(), 0, 0));

the "idle" handle is add in NetServerImpl before when you set NetServerOption.IdleTimeout > 0

@Sammers21
Copy link
Contributor

Ah, I see. You are right. We have already fixed the issue in the MQTT client. See the PR: #79.

I think we can do the same thing for MQTT server.

@dushibaiyu, are you interested in contribution?

@dushibaiyu
Copy link
Author

I have created a Pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants