Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setMetricsTrackerFactory of HikariConfig #182

Open
mgaidamak opened this issue Mar 27, 2020 · 1 comment
Open

Support setMetricsTrackerFactory of HikariConfig #182

mgaidamak opened this issue Mar 27, 2020 · 1 comment
Labels
enhancement

Comments

@mgaidamak
Copy link

Is there any reasons to not support HikariConfig.setMetricsTrackerFactory at this block of HikariCPDataSourceProvider?

        case "metricRegistry":
          throw new UnsupportedOperationException(entry.getKey());

Can I submit a pool request?
Thanks
@vietj
Copy link
Contributor

vietj commented Mar 27, 2020

you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vietj @mgaidamak