New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SockJS Eventbus hook incomplete #9

Open

darkredz opened this issue Oct 10, 2013 · 0 comments

Assignees

darkredz commented Oct 10, 2013

I found that the SockJS implementation in mod php isn't complete:
public SockJSServer setHook(Env env, ObjectValue hook) {
return this;
}

It should reflect what the Java api did at https://github.com/eclipse/vert.x/blob/master/vertx-core/src/main/java/org/vertx/java/core/sockjs/impl/DefaultSockJSServer.java

public SockJSServer setHook(EventBusBridgeHook hook) {
this.hook = hook;
return this;
}

Not quite sure how do you map this back to a language mod like mod php.

ghost assigned kuujo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment