You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes. That's a good idea. They can be simplified. But if we do that we have to write some tests for the current implementation. Some of the workers are covered by tests, some not. If we have a 90% test coverage for the existing workers then we can start refactoring. This part is very critical.
I noticed that most of
CrawlWorker
are duplicating thework
method, which could be moved into parent class like theGosearchVersionWorker
does: https://github.com/versioneye/crawl_r/blob/master/lib/versioneye/workers/crates_crawl_worker.rbThe text was updated successfully, but these errors were encountered: