Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Every CrawlWorker has same implementation of work function #62

Open
timgluz opened this issue Jul 6, 2017 · 1 comment
Open

Comments

@timgluz
Copy link
Contributor

timgluz commented Jul 6, 2017

I noticed that most of CrawlWorker are duplicating the work method, which could be moved into parent class like the GosearchVersionWorker does: https://github.com/versioneye/crawl_r/blob/master/lib/versioneye/workers/crates_crawl_worker.rb

@reiz
Copy link
Member

reiz commented Jul 7, 2017

Yes. That's a good idea. They can be simplified. But if we do that we have to write some tests for the current implementation. Some of the workers are covered by tests, some not. If we have a 90% test coverage for the existing workers then we can start refactoring. This part is very critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants