Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long names in flattened model #28

Open
stanleybak opened this issue Mar 29, 2016 · 0 comments
Open

long names in flattened model #28

stanleybak opened this issue Mar 29, 2016 · 0 comments

Comments

@stanleybak
Copy link
Contributor

When flattening and merging with a single-mode automaton, it shouldn't be necessary to add its name to the resultant mode. This will result in shorter names:

The general logic for chosing a name (in mergeLocations() of FlattenAutomatonPass.java) should be:

if (right.modes.size() == 1)
    combinedName = locI.name;
else if (left.modes.size() == 1)
    combinedName = locJ.name;
else
    combinedName = locI.name + SEPARATOR + locJ.name;

The transitions and initial / forbidden states should also be adjusted, and likely unit tests will need to be updated to expect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant