Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup in order reduction pass #23

Open
stanleybak opened this issue Feb 3, 2016 · 0 comments
Open

Cleanup in order reduction pass #23

stanleybak opened this issue Feb 3, 2016 · 0 comments
Labels
enhancement

Comments

@stanleybak
Copy link
Contributor

I noticed two things looking through the code which we may want to clean up:

  1. There is a general catch(Exception e). Exceptions should generally be more specific (for example NumberFormatException rather than catching the superclass Exception, as was written in our style guide.
  2. automaton validation was turned off: config.DO_VALIDATION = false;. Why was this necessary?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stanleybak