-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP:Joezhong fix 320 #323
WIP:Joezhong fix 320 #323
Conversation
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 70.62% 70.94% +0.33%
==========================================
Files 168 168
Lines 11492 11696 +204
Branches 1874 1935 +61
==========================================
+ Hits 8115 8297 +182
- Misses 2891 2904 +13
- Partials 486 495 +9
Continue to review full report at Codecov.
|
…oezhong-fix-320 # Conflicts: # src/main/java/org/verdictdb/coordinator/ExecutionContext.java
…oezhong-fix-320 # Conflicts: # src/main/java/org/verdictdb/coordinator/ExecutionContext.java
@pyongjoo |
…f set operation when one table is scrambled and another is not scrambled.
…oezhong-fix-320 # Conflicts: # src/main/java/org/verdictdb/sqlreader/ScrambleTableReplacer.java
…oezhong-fix-320 # Conflicts: # src/main/java/org/verdictdb/sqlreader/ScrambleTableReplacer.java
Related Issue #320
Sorry for the delay. I tried to solve the case when scramble tables are involved in set operation. Currently, no AsyncAggExecutionNode is created if scramble tables are in set operation. The reason is that VerdictDB will select and group by verditdbtier column. However, in set operation, the number of selected columns should be the same. For instance,
select count(something) from (select something from scramble_table UNION select something from normal_table)
If we try to use AsyncAggExecutionNode here, the query created by the individual AggExecutionNode will become like
select something, verdictdbtier from scramble_table where verdictdbblock>=0 UNION select something from normal_table