chore: bump next-auth
#491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
delbaoliveira
approved these changes
Nov 28, 2023
nemchik
reviewed
Nov 28, 2023
Comment on lines
+130
to
+136
| if (error instanceof AuthError) { | ||
| switch (error.type) { | ||
| case 'CredentialsSignin': | ||
| return 'Invalid credentials.'; | ||
| default: | ||
| return 'Something went wrong.'; | ||
| } |
There was a problem hiding this comment.
Should there be a return type outside of this condition (or in an else) to catch when error instanceof AuthError returns false?
There was a problem hiding this comment.
Those errors are thrown further down. It's not the task of the authenticate method. There are special throws as well that powers redirect() (used internally by signIn) which should not be handled and let Next.js/React handle them with their error boundaries.
If the error is an AuthError, we already know how to handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps NextAuth.js to the latest version.
The main noticeable change is cleaner error handling: Whenever a NextAuth.js-induced error happens in a Server Action, we now throw an
AuthErrorinstance that makes error handling a bit easier.In addition, this new release includes bug fixes. See the release notes: https://github.com/nextauthjs/next-auth/releases/tag/next-auth%405.0.0-beta.4
Slack thread