Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users shouldn't need to know the full API entrypoint(s) #20

Open
thomas-fossati opened this issue Aug 24, 2022 · 1 comment
Open

users shouldn't need to know the full API entrypoint(s) #20

thomas-fossati opened this issue Aug 24, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@thomas-fossati
Copy link
Contributor

Since we do know the entry points for endorsement and evidence submission (they are fully specified by the API documentation) we shouldn't require the user of the package to specify the full URI, only the base. I.e., rather than https://veraison.example/challenge-response/v1/newSession, the user should supply https://veraison.example/challenge-response/v1. (The same for the endorsement API).

@thomas-fossati thomas-fossati added the enhancement New feature or request label Aug 24, 2022
@thomas-fossati
Copy link
Contributor Author

thomas-fossati commented Aug 24, 2022

For endorsements SubmitConfig.SubmitURI should be renamed to SubmitConfig.BaseURI and the /submit path segment automatically appended to it. (Same for ChallengeResponseConfig.NewSessionURI, except the path segment is /newSession.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants