Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n support #2

Open
michaelbromley opened this issue Mar 25, 2019 · 1 comment
Open

i18n support #2

michaelbromley opened this issue Mar 25, 2019 · 1 comment

Comments

@michaelbromley
Copy link
Member

The strings need to be localizable. I suggest we use the same approach as with the admin-ui, i.e. ngx-translate + ICU message format JSON files.

Should expose the translate pipe via the VendureStorefrontModule for use in the consuming app, so it can use the same i18n infrastructure as the library.
@michaelbromley
Copy link
Member Author

Started implementing the above plan but ran into an issue where the ng cli does not yet support copying assets from a library. I need this for the translation files of ngx-translate.

See angular/angular-cli#11071. From the discussion there it looks like it may be possible with Angular v8, but I cannot find any documentation about how.

This issue will be put on hold until it is clear how to copy the library assets.

michaelbromley added a commit that referenced this issue Apr 23, 2019
@michaelbromley
feat: Update Angular deps, add i18n infrastructure
770d7ea 
Full implementation is not yet possible due to not being able to copy assets in the library, see #2 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelbromley